How AOP makes my life easier

Written on August 10, 2016

Here at VetVision, we build a complex web app with a massive database call in a single request. Yes its by design! the idea was serving an aggregate view for user, so it makes user life easier - yet us as the developer.

The good thing when working with ASP.Net MVC is you are free to create child action as many as you like to prevent duplication. Its great! but it also introduce another problem. Imagine you have a RocketScienceController like below

public class RocketScienceController : Controller 
{
    public ActionResult Index()
    {
        var userDetail = db.GetUserDetail();
        //other process
        return View();
    }

    [ChildOnly]
    public ActionResult MyPopup()
    {
        var userDetail = db.GetUserDetail();
        //other process
        return PartialView();
    }
}

User info is required in the Index action and also MyPopup action. so it called separately in each action.

Notice any problem yet? No? no problem because the real problem occurs in the cshtml. Imagine if the RocketScienceController/Index view hosting the popup like below

<div class="body">
    <!-- other html elemets -->

    @Html.Action("MyPopup")
</div>

Now you notice the problem. On every request of RocketScienceController/Index will call db.GetUserDetail() twice, with non modular approach (without Child Action) it only need to call once. Is there a way to avoid it? Yes there are many ways, but the path will be difficult.

GLOBAL CACHING

I found than the easiest way to solve the problem is by adding global caching on each method call. Lets assume that i have created a Global Cache provider that use Asp.Net Cache Provider, with timeout set to 5 seconds. Why 5 seconds? its depends on how often the data will be changed, in our apps the data change is quite fast, so I set the cache timeout equals with how fast my server will provide a single request. I put average estimation time to 5 seconds. So when a user commit a data change, on the next request the cache is already timeout, and user provided with the new data not the cache. My RocketScienceController then changed like below:

public class RocketScienceController : Controller 
{
    const string UserDetailCache = "GetUserDetail";
    public ActionResult Index()
    {
        var userDetail = cacheProvider.Get<UserDetailModel>(UserDetailCache);
        if(userDetail == null)
        {
            userDetail = db.GetUserDetail();
            cacheProvider.Set(UserDetailCache, userDetail);
        }
        //other process
        return View();
    }

    [ChildOnly]
    public ActionResult MyPopup()
    {
        var userDetail = cacheProvider.Get<UserDetailModel>(UserDetailCache);
        if(userDetail == null)
        {
            userDetail = db.GetUserDetail();
            cacheProvider.Set(UserDetailCache, userDetail);
        }
        //other process
        return PartialView();
    }
}

From performance perspective, the page will be run efficiently, because
db.GetUserDetail() only called once, the next call (on the same request) will be provided from the cache. Neat! but from programmer perspective it introduce more problem. Imagine if you have 5 method calls in one action it will make the overall code hard to read.

ENTER THE AOP

Almost all projects here at VetVision developed using Dependency Injection framework, using Castle Windsor. Best thing about Castle Windsor is its API clairity and its support to Interception by using Interception we can do a simple AOP by providing an Advice in the interceptor.

By reviewing the last RocketScienceController code, we can use Interception and remove all if - else brace and just leave the db.GetUserDetail() call. The interceptor is like below.

public class CoolCacheInterceptor : IInterceptor
{
    public void Intercept(IInvocation invocation)
    {
        var cacheId = CreateId(invocation)
        var cache = cacheProvider.Get<object>(cacheId);
        if(cache == null)
        {
            cache = invocation.Proceed();
            cacheProvider.Set(cacheId, cache);
        }
        invocation.ReturnValue = cache;
    }

    private string CreateId(IInvocation invocation)
    {
        var methodName = invocation.Method.ToString();
        var arguments = invocation.Arguments.Select(a => a.ToString()).ToArray();
        var argsString = string.Join(",", arguments);
        var cacheKey = methodName + "-" + argsString;
        return cacheKey;
    }
}

I make the example of CreateId as simple as possible, so you will understand the idea of the cache ID is to create a unique ID based on method name and its parameters. This implementation only allowed for primitive type parameters, but for custom class will need to override the ToString() method to get a unique id. I have a plan to make another blog post about this cache technique so it can be use to crate a unique id for a method that using custom class without having to do some change on the class itself.

Back to our RocketScienceController we need to make a little modification, with Constructor Injection.

public class RocketScienceController : Controller 
{
    IDataContext db;
    public RocketScienceController(IDataContext db)
    {
        this.db = db;
    }

    public ActionResult Index()
    {
        var userDetail = db.GetUserDetail();
        //other process
        return View();
    }

    [ChildOnly]
    public ActionResult MyPopup()
    {
        var userDetail = db.GetUserDetail();
        //other process
        return PartialView();
    }
}

See the difference with previous code? yes its call to db.GetUserDetail() seems like it doesn’t use cache at all, but it does!

What was happened behind the scene? Castle Windsor creates an object proxy of the IDataContext interface. So before the actual GetUserDetail() implementation called, Castle Windsor will first call the interceptor. The actual method is called when the invocation.Proceed() method is called. So with the process, you can specify wether your code will be called before or after the actual code executed.

To complete the setup, here is how the interception registered.

container.Register(           
    Component.For<IDataContext>()
        .ImplementedBy<MyDataContext>()
        .Interceptors<CoolCacheInterceptor>()
        .LifestyleTransient());

Thats it!

Like you see with AOP all codding style remain the same without need to understand about caching and all its setups, thats really make all team happy, with a bonus in performance which make my Boss happy! :)